[Intel-gfx] [PATCH v3 10/14] drm/i915/uc: Add message with firmware url

[Michal Wajdeczko]

On Fri, 13 Oct 2017 01:20:05 +0200, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2017-10-12 23:54:43)
>> diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h  
>> b/drivers/gpu/drm/i915/intel_uc_fw.h
>> index 5c01849..1d580fa 100644
>> --- a/drivers/gpu/drm/i915/intel_uc_fw.h
>> +++ b/drivers/gpu/drm/i915/intel_uc_fw.h
>> @@ -27,6 +27,8 @@
>>
>>  struct drm_i915_private;
>>
>> +#define INTEL_UC_FIRMWARE_URL  
>> "https://01.org/linuxgraphics/downloads/firmware"
>
> Pull it out from intel_csr.c, say intel_drv.h?

Well, the secret plan was to update intel_csr.c in separate patch.
Then we could fix message there to be more clear and user friendly,
as today URL is in place where one will expect firmware filename:

    "Failed to load DMC firmware"
    " [" FIRMWARE_URL "],"
    " disabling runtime power management.\n");

And for location of the URL macro, I still prefer intel_uc_fw.h
over intel_drv.h, as the latter one is little overloaded, while
former is still accessible to csr.c and there is a chance to
even reuse more uc_fw functions in csr.c in the future.

Michal