[Intel-gfx] [PATCH v4 10/14] drm/i915/uc: Add message with firmware url

Chris Wilson chris at chris-wilson.co.uk
Fri Oct 13 11:52:17 UTC 2017


Quoting Chris Wilson (2017-10-13 12:50:53)
> Quoting Michal Wajdeczko (2017-10-13 12:11:33)
> > diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h
> > index 5c01849..1d580fa 100644
> > --- a/drivers/gpu/drm/i915/intel_uc_fw.h
> > +++ b/drivers/gpu/drm/i915/intel_uc_fw.h
> > @@ -27,6 +27,8 @@
> >  
> >  struct drm_i915_private;
> >  
> > +#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware"
> 
> We already have this define in intel_csr.c, so let's reuse it.

Or make it clear in the commit log the duplication is fixed in the next
patch.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list