[Intel-gfx] [PATCH i-g-t 2/2] tests/drm_read: Change tests to not require fbcon

[Chris Wilson]

Quoting Maarten Lankhorst (2017-10-13 15:10:49)
> The first active pipe might not be pipe A, and we shouldn't rely on
> fbcon for a working crtc. Use igt_kms to set up something basic, and
> use the kmstest helper to get an event from the correct pipe.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

If one is lazy enough, some one will be foolhardy enough to try turning
off all outputs and fixup the fallout. Not the most catchy of sayings,
but true in this case.

> ---
>  tests/drm_read.c | 62 +++++++++++++++++++++++++++++++-------------------------
>  1 file changed, 34 insertions(+), 28 deletions(-)
> 
> diff --git a/tests/drm_read.c b/tests/drm_read.c
> index 7df36e965c59..b6aab731261d 100644
> --- a/tests/drm_read.c
> +++ b/tests/drm_read.c
> @@ -57,18 +57,9 @@ static void assert_empty(int fd)
>         do_or_die(poll(&pfd, 1, 0));
>  }
>  
> -static void generate_event(int fd)
> +static void generate_event(int fd, enum pipe pipe)
>  {
> -       union drm_wait_vblank vbl;
> -
> -       /* We require that pipe 0 is running */
> -
> -       vbl.request.type =
> -               DRM_VBLANK_RELATIVE |
> -               DRM_VBLANK_EVENT;
> -       vbl.request.sequence = 0;
> -
> -       do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl);
> +       igt_assert(kmstest_get_vblank(fd, pipe, DRM_VBLANK_EVENT));
>  }

Now this is pipe-aware, is there any variation between pipes? Any
advantage in extending the test? Well that should already be kms_vblank.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris