[Intel-gfx] [PATCH 04/11] drm/i915: Move workarounds from init_clock_gating

[Oscar Mateo]

<SNIP>


On 10/11/2017 11:35 AM, Ville Syrjälä wrote:
> On Wed, Oct 11, 2017 at 11:15:14AM -0700, Oscar Mateo wrote:
>> I'm not sure why some WAs have historically been applied in init_clock_gating
>> and some others in the engine setup (GT vs. display? context vs. global
>> registers?) but it does not look like the best place to apply workarounds:
>> the name is confusing, it's a display function (even though some GT WAs
>> also go here) and it isn't necessarily called on a GPU reset. This patch
>> moves these WAs to their rightful place inside i915_workarounds.c.
>>
>> TODO: Do we want to keep display WAs separated from GT ones? In that case,
>> I would propose another category inside i915_workarounds.c (but I would need
>> help deciding what goes where).
> The current situation isn't very good. But neither really is moving
> display stuff into something called gem_init_hw(). It also gets called
> during GPU reset which is at the very least wasted effort when it comes
> to display w/as, and could even be actively harmful in case we end up
> clobbering something the current display configuration depends on.


Ok, fully agree. I'm sending a new version with separate GT and Display 
workarounds.

Thanks!
Oscar