[Intel-gfx] [PATCH 04/11] drm/i915: Move workarounds from init_clock_gating

Oscar Mateo oscar.mateo at intel.com
Fri Oct 13 20:52:45 UTC 2017



On 10/11/2017 11:29 AM, Chris Wilson wrote:
> Quoting Oscar Mateo (2017-10-11 19:15:14)
>> I'm not sure why some WAs have historically been applied in init_clock_gating
>> and some others in the engine setup (GT vs. display? context vs. global
>> registers?) but it does not look like the best place to apply workarounds:
>> the name is confusing, it's a display function (even though some GT WAs
>> also go here) and it isn't necessarily called on a GPU reset. This patch
>> moves these WAs to their rightful place inside i915_workarounds.c.
>>
>> TODO: Do we want to keep display WAs separated from GT ones? In that case,
>> I would propose another category inside i915_workarounds.c (but I would need
>> help deciding what goes where).
>>
>> v2:
>>    - Also move bdw and chv WAs from init_clock_gating that do not seem to be
>>      actually related to clock gating.
>>    - Rebased.
> Too much in one patch. Start with copy'n'paste, and then we can see
> which w/a you select to move from init_clock_gating.
> -Chris

Even better: I'll make the movement from init_clock_gating in small 
chunks, one per GEN/platform.


More information about the Intel-gfx mailing list