[Intel-gfx] [PATCH] drm/i915: Stop asserting on set-wedged vs nop_submit_request ordering

Chris Wilson chris at chris-wilson.co.uk
Sat Oct 14 17:05:43 UTC 2017


Quoting Mika Kuoppala (2017-10-13 15:23:41)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Since the removal of the stop_machine(), it is allowed and expected for
> > the nop_submit_request() and nop_complete_submit_request() to run in
> > parallel to the i915_gem_set_wedged() processing. As such we can no
> > longer assert that i915_gem_set_wedged() has completed inside the
> > stop_machine prior to the individual nop_submit_request execution.
> >
> > Fixes: af7a8ffad9c5 ("drm/i915: Use rcu instead of stop_machine in set_wedged")
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter at intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> 
> from irc:
> 17:12 < danvet> r-b: me
> 
> also,
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

Applied but it didn't fix snb; it still dies silently in
gem_eio/suspend. I knew it was a long shot, but the only one I had. :|

If CI isn't giving us the info we need, I guess I'll just have to try
locally.
-Chris


More information about the Intel-gfx mailing list