[Intel-gfx] [PATCH v4 07/14] drm/i915/guc: Move firmware size check out of generic code

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Oct 16 12:45:52 UTC 2017


On Fri, 2017-10-13 at 11:11 +0000, Michal Wajdeczko wrote:
> Checking GuC firmware size can be done in GuC specific code
> right before DMA copy as it is unlikely to fail anyway.
> 
> v2: rebased
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com> #1

<SNIP>

So, lets move this code under the "uc_fw->ucode_size = (css->size_dw -
css->header_size_dw) * sizeof(u32);" line and consider any firmware
with conflicting information a corrupt file.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list