[Intel-gfx] [PATCH v2] drm/i915: Skip HW reinitialisation on resume if still wedged

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 16 20:15:22 UTC 2017


Quoting Mika Kuoppala (2017-10-16 16:30:33)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > If we fail to recover the HW state upon resume (i.e. our attempt to
> > clear the wedged bit and reset during i915_gem_sanitize() fails), then
> > skip the HW restart inside i915_gem_init_hw(). We will ultimately do the
> > HW restart when successfully unwedging and resetting the HW later,
> > but attempting to restore a wedged device upon resume is risky as the HW
> > is in an unknown state.
> >
> > v2: Suppress the error message when detecting the already wedged HW.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> 
> Stamping the right version is also a helpful.
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

Thanks for taking the time to question the code carefully. This clears
up CI, but I am still able to kill snb at the moment with
gem_exec_whisper/hang-normal (though since we have reset enabled, it
looks to be a different problem).

One step forward, and pushed,
-Chris


More information about the Intel-gfx mailing list