[Intel-gfx] [PATCH v3 10/22] drm/i915: Move WA BB stuff to the workarounds file as well

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 17 12:49:37 UTC 2017


Quoting Oscar Mateo (2017-10-13 21:54:04)
> Since we are trying to put all WA stuff together, do not forget about the BB WAs.
> 
> Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.h b/drivers/gpu/drm/i915/intel_workarounds.h
> index 44d3941..2d7ea51 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.h
> +++ b/drivers/gpu/drm/i915/intel_workarounds.h
> @@ -35,4 +35,7 @@
>  int intel_whitelist_workarounds_init(struct intel_engine_cs *engine);
>  void intel_whitelist_workarounds_apply(struct intel_engine_cs *engine);
>  
> +int intel_bb_workarounds_init(struct intel_engine_cs *engine);
> +void intel_bb_workarounds_fini(struct intel_engine_cs *engine);

I looked at this and thought, intel_engine_init_bb_workarounds. Because
they are engine specific and stored on the engine.

I'm not fussed, and I think the motion from lrc.c worth it. Especially
if it means we get a consistent means of logging all the w/a we apply
and can quickly search for ones we missed.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list