[Intel-gfx] [PATCH v3 20/22] drm/i915/bdw: Move GT and Display workarounds from init_clock_gating

[Chris Wilson]

Quoting Oscar Mateo (2017-10-13 21:54:14)
> @@ -840,6 +859,30 @@ static int display_wa_add(struct drm_i915_private *dev_priv,
>  
>  static int bdw_display_workarounds_init(struct drm_i915_private *dev_priv)
>  {
> +       enum pipe pipe;
> +
> +       /* WaPsrDPAMaskVBlankInSRD:bdw */
> +       DISPLAY_WA_SET_BIT(CHICKEN_PAR1_1, DPA_MASK_VBLANK_SRD);
> +
> +       /* WaPsrDPRSUnmaskVBlankInSRD:bdw */
> +       for_each_pipe(dev_priv, pipe) {
> +               DISPLAY_WA_SET_BIT(CHICKEN_PIPESL_1(pipe),
> +                                  BDW_DPRS_MASK_VBLANK_SRD);

Do we have pipes this early?

Eeek, I wonder if I missed any other questions like that...
-Chris