[Intel-gfx] [PATCH i-g-t v2 1/4] lib: Extract helpers for determining submission method

[Chris Wilson]

Quoting Chris Wilson (2017-10-18 00:01:35)
> Quoting Michał Winiarski (2017-10-16 10:05:14)
> > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > index fa6594c3..cacc8f98 100644
> > --- a/lib/igt_aux.c
> > +++ b/lib/igt_aux.c
> > @@ -1455,6 +1455,24 @@ igt_show_stat(proc_t *info, int *state, const char *fn)
> >         ++*state;
> >  }
> >  
> > +void gem_show_submission_method(int fd)
> > +{
> > +       const unsigned flags = gem_submission_method(fd);
> > +
> > +       if (flags & GEM_SUBMISSION_GUC) {
> > +               igt_info("Using GuC submission\n");
> > +               return;
> > +       }
> > +
> > +       if (flags & GEM_SUBMISSION_EXECLISTS) {
> > +               igt_info("Using Execlists submission\n");
> > +               return;
> > +       }
> > +
> > +       igt_info("Using Legacy submission%s\n",
> > +                flags & GEM_SUBMISSION_SEMAPHORES ? ", with semaphores" : "");
> > +}
> 
> You managed to hide it inside an #ifdef HAVE_PROCPS, or how to confuse
> me with weird build failures.
> 
> Don't we have a lib/i915/gem_scheduler.c for this now?

Ok, scheduler isn't a good fit, do I hear a cry of
lib/i915/gem_submission.c?
-Chris