[Intel-gfx] [PATCH] drm/i915: Add Guc/HuC firmware details to error state

[Chris Wilson]

Quoting Michal Wajdeczko (2017-10-19 13:57:06)
> @@ -774,6 +793,11 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
>         err_print_capabilities(m, &error->device_info);
>         err_print_params(m, &error->params);
>  
> +       if (HAS_GUC(dev_priv)) {

Could we not peek inside the struct to know if it has been set? Looking
at the current device should be a last resort -- better to assume that
everything and anything may have been overwritten since the error.

> +               intel_uc_fw_dump(&dev_priv->guc.fw, &p);
> +               intel_uc_fw_dump(&dev_priv->huc.fw, &p);
> +       }

Looks really useful, thanks.
-Chris