[Intel-gfx] [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails.
Maarten Lankhorst
maarten.lankhorst at linux.intel.com
Wed Oct 25 07:56:00 UTC 2017
Op 25-10-17 om 03:36 schreef Pandiyan, Dhinakaran:
> On Wed, 2017-10-11 at 12:28 +0200, Maarten Lankhorst wrote:
>> Op 10-10-17 om 22:12 schreef Chris Wilson:
>>> Quoting Maarten Lankhorst (2017-10-10 17:04:27)
>>>> Make sure read_all_entries has all outputs possible enabled, but also
>>>> add a test that runs with all outputs disabled.
>>>>
>>>> This will maximize coverage of debugfs reading, and allows the test not
>>>> to be dependent on fbcon for setup.
>>>>
>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>>> My only argument, but this is just one special case out of many, isn't
>>> really an argument but an endorsement.
>>>
>>> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
>>> -Chris
>> This test seems to cause a failure in igt..
>>
>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_315/fi-glk-1/igt@debugfs_test@read_all_entries.html
>>
>> Dhinakaran, any idea about the DP crc failure?
>>
>> ~Maarten
>>
> I accidentally reproduced this by reading the CRC debugfs when eDP was
> off (pipe was active as per i915_display_info). Wonder if this is an
> indication that the panel did not really light up in your case. It'd be
> good to see what's happening on the screen if you have physical access
> to the machine.
Never mind, I've tracked it down to the enable sequence, when I enable
the connector butnot the primary plane I get this warning. Once I also
enabled the primary plane in the next version I was able to read a CRC. :)
thanks for the help,
Maarten
More information about the Intel-gfx
mailing list