[Intel-gfx] [PATCH] drm/i915: Add -Wall -Wextra to our build, set warnings to full

[Chris Wilson]

Quoting Jani Nikula (2017-10-26 15:36:34)
> On Tue, 24 Oct 2017, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression
> > that had been lurking for 6 months, so lets try enabling the full set of
> > warnings for CI builds. This means more patches will be rejected early
> > that contain trivial and sometimes not so trivial bugs. However, our
> > code does not yet compile cleanly with W=1, so we have to apply a filter
> > to the set of warnings until we can eliminate the mistakes. It also
> > means that developers will have to be running the full gamut of gcc to
> > ensure that as warnings come and go with gcc updates, we have the CI
> > build prepared.
> >
> > v2: Use fine-grained -Wno overrides. Inside the makefile, we can
> > specify CFLAGS on a per-object level, which allows us to limit the scope
> > of any particular warning override.
> > v3: Place per-file overrides after the main enabling block.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Tomi Sarvela <tomi.p.sarvela at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Acked-by: Tomi Sarvela <tomi.p.sarvela at intel.com>
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > ---
> > Seeking more acks for making our lives harder by giving gcc free reign
> > in its warnings.
> 
> Acked-by: Jani Nikula <jani.nikula at intel.com>

So be it. I hope I don't regret letting gcc rule over us!
-Chris