[Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled

Dhinakaran Pandiyan dhinakaran.pandiyan at intel.com
Thu Oct 26 23:51:37 UTC 2017


The frontbuffer_tracking PSR tests fail if PSR cannot be activated when
there is sink support. But, there are several other requirements related to
mode timings that have to be satisfied before PSR can be enabled. No reason
to fail these tests when PSR cannot be enabled.

v2: Check for Source_OK instead of Enabled (Paulo)

Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
---
 tests/kms_frontbuffer_tracking.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index a068c8af..17af4bbd 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1548,12 +1548,13 @@ static void teardown_fbc(void)
 {
 }
 
-static bool psr_sink_has_support(void)
+static bool psr_has_support(void)
 {
 	char buf[256];
 
 	debugfs_read("i915_edp_psr_status", buf);
-	return strstr(buf, "Sink_Support: yes\n");
+	return strstr(buf, "Sink_Support: yes\n") &&
+	       strstr(buf, "Source_OK: yes\n");
 }
 
 static void setup_psr(void)
@@ -1564,8 +1565,8 @@ static void setup_psr(void)
 		return;
 	}
 
-	if (!psr_sink_has_support()) {
-		igt_info("Can't test PSR: not supported by sink.\n");
+	if (!psr_has_support()) {
+		igt_info("Can't test PSR: not supported.\n");
 		return;
 	}
 	psr.can_test = true;
-- 
2.11.0



More information about the Intel-gfx mailing list