[Intel-gfx] [PATCH 1/2] drm/i915/fbc: intel_fbc.crtc and intel_fbc.enabled are synonymous

[Chris Wilson]

Quoting Ville Syrjälä (2017-10-27 20:56:44)
> On Fri, Oct 27, 2017 at 08:42:39PM +0100, Chris Wilson wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
> > index 1a0f5e0c8d10..f4c3a3b9a8e6 100644
> > --- a/drivers/gpu/drm/i915/intel_fbc.c
> > +++ b/drivers/gpu/drm/i915/intel_fbc.c
> > @@ -472,7 +472,7 @@ static void intel_fbc_schedule_activation(struct intel_crtc *crtc)
> >       struct intel_fbc_work *work = &fbc->work;
> >  
> >       WARN_ON(!mutex_is_locked(&fbc->lock));
> > -     if (WARN_ON(!fbc->enabled))
> > +     if (WARN_ON(fbc->crtc != crtc))
> >               return;
> 
> I was a bit worried that this might trip needlessly, but looks like
> __intel_fbc_post_update() should keep that from happening.

Yeah, I was actually wondering if we might trip this and explain a few
of the oddities. :)
-Chris