[Intel-gfx] [i-g-t] assembler: Fix bashism in run-test.sh

Rhys Kidd rhyskidd at gmail.com
Sun Oct 29 00:20:18 UTC 2017


[[ a != b ]] is a bashism. As it's just comparing $1 to an empty string,
use -n with a normal [ ].

Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI.

Also change the script to #!/bin/bash to avoid having to babysit bashism later.

Fixes: c3863e19 ("assembler/test: Prep work for meson")
CC: Daniel Vetter <daniel.vetter at ffwll.ch>
CC: Petri Latvala <petri.latvala at intel.com>
Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
---
 assembler/test/run-test.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/assembler/test/run-test.sh b/assembler/test/run-test.sh
index 0a5252a8..b5e245bc 100644
--- a/assembler/test/run-test.sh
+++ b/assembler/test/run-test.sh
@@ -1,11 +1,11 @@
-#!/bin/sh
+#!/bin/bash
 
 SRCDIR=${srcdir-`pwd`}
 BUILDDIR=${top_builddir-`pwd`}
 
 test="TEST"
 
-if [[ "$1" != "" ]] ; then
+if [ -n "$1" ] ; then
 	test="$1"
 fi
 
-- 
2.14.1



More information about the Intel-gfx mailing list