[Intel-gfx] [i-g-t v2] assembler: Fix bashism in run-test.sh

Arkadiusz Hiler arkadiusz.hiler at intel.com
Mon Oct 30 17:59:12 UTC 2017


On Mon, Oct 30, 2017 at 09:09:41AM -0400, Rhys Kidd wrote:
> [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string,
> use -n with a normal [ ].
> 
> Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI.
> 
> v2:
>  - keep this as a /bin/sh script (Joonas Lahtinen)
> 
> Fixes: c3863e19 ("assembler/test: Prep work for meson")
> CC: Daniel Vetter <daniel.vetter at ffwll.ch>
> CC: Petri Latvala <petri.latvala at intel.com>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>

Thanks for patch and the review!
Pushed.

-- 
Cheers,
Arek


More information about the Intel-gfx mailing list