[Intel-gfx] [PATCH 1/2] drm/i915: Remove i915.enable_execlists module parameter

[Lionel Landwerlin]

I can't speak for the totality of the driver, but the perf part is :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 26/10/17 22:17, Chris Wilson wrote:
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 59ee808f8fd9..8dfa74bd3f37 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -1214,9 +1214,9 @@ static int oa_get_render_ctx_id(struct i915_perf_stream *stream)
>   {
>   	struct drm_i915_private *dev_priv = stream->dev_priv;
>   
> -	if (i915_modparams.enable_execlists)
> +	if (HAS_LOGICAL_RING_CONTEXTS(dev_priv)) {
>   		dev_priv->perf.oa.specific_ctx_id = stream->ctx->hw_id;
> -	else {
> +	} else {
>   		struct intel_engine_cs *engine = dev_priv->engine[RCS];
>   		struct intel_ring *ring;
>   		int ret;
> @@ -1260,7 +1260,7 @@ static void oa_put_render_ctx_id(struct i915_perf_stream *stream)
>   {
>   	struct drm_i915_private *dev_priv = stream->dev_priv;
>   
> -	if (i915_modparams.enable_execlists) {
> +	if (HAS_LOGICAL_RING_CONTEXTS(dev_priv)) {
>   		dev_priv->perf.oa.specific_ctx_id = INVALID_CTX_ID;
>   	} else {
>   		struct intel_engine_cs *engine = dev_priv->engine[RCS];
> @@ -3412,7 +3412,7 @@ void i915_perf_init(struct drm_i915_private *dev_priv)
>   		dev_priv->perf.oa.timestamp_frequency = 12500000;
>   
>   		dev_priv->perf.oa.oa_formats = hsw_oa_formats;
> -	} else if (i915_modparams.enable_execlists) {
> +	} else if (HAS_LOGICAL_RING_CONTEXTS(dev_priv)) {
>   		/* Note: that although we could theoretically also support the
>   		 * legacy ringbuffer mode on BDW (and earlier iterations of
>   		 * this driver, before upstreaming did this) it didn't seem