[Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

[Ville Syrjälä]

On Fri, Sep 01, 2017 at 10:51:00AM +0300, Mika Kahola wrote:
> According to spec we should send SHUTDOWN before MIPI_SEQ_DISPLAY_OFF for
> v3+ VBT's. Testing with VBT v3 the current implementation yields the
> following error message
> 
> *ERROR* Video mode command 0x00000041 send failed.
> 
> To get rid of this error message, let's limit SHUTDOWN only for VBT
> versions 3 or higher.

In the patch you limit it to version 4+, which doesn't make sense since
AFAIK there is no version 4 of the sequence block.

> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
> Signed-off-by: Mika Kahola <mika.kahola at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 2a0f5d3..b48b9b7 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -916,7 +916,7 @@ static void intel_dsi_disable(struct intel_encoder *encoder,
>  	 * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing
>  	 * has shown that the v3 sequence works for v2 VBTs too
>  	 */
> -	if (is_vid_mode(intel_dsi)) {
> +	if (is_vid_mode(intel_dsi) && dev_priv->vbt.dsi.seq_version > 3) {
>  		/* Send Shutdown command to the panel in LP mode */
>  		for_each_dsi_port(port, intel_dsi->ports)
>  			dpi_send_cmd(intel_dsi, SHUTDOWN, false, port);
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC