[Intel-gfx] [PATCH 3/3] drm/i915: Fix enum pipe vs. enum transcoder for the PCH transcoder

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 1 14:43:38 UTC 2017


Quoting ville.syrjala at linux.intel.com (2017-09-01 15:31:23)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Use enum pipe for PCH transcoders also in the FIFO underrun code.
> 
> Fixes the following new sparse warnings:
> intel_fifo_underrun.c:340:49: warning: mixing different enum types
> intel_fifo_underrun.c:340:49:     int enum pipe  versus
> intel_fifo_underrun.c:340:49:     int enum transcoder
> intel_fifo_underrun.c:344:49: warning: mixing different enum types
> intel_fifo_underrun.c:344:49:     int enum pipe  versus
> intel_fifo_underrun.c:344:49:     int enum transcoder
> intel_fifo_underrun.c:397:57: warning: mixing different enum types
> intel_fifo_underrun.c:397:57:     int enum pipe  versus
> intel_fifo_underrun.c:397:57:     int enum transcoder
> intel_fifo_underrun.c:398:17: warning: mixing different enum types
> intel_fifo_underrun.c:398:17:     int enum pipe  versus
> intel_fifo_underrun.c:398:17:     int enum transcoder
> 
> Cc: Matthias Kaehlcke <mka at chromium.org>
> Fixes: a21960339c8c ("drm/i915: Consistently use enum pipe for PCH transcoders")
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

C types are consistent, so
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

I have not checked if the semantics are correct...
-Chris


More information about the Intel-gfx mailing list