[Intel-gfx] [PATCH 1/2] drm/i915: Add __rcu to radix tree slot pointer

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 1 18:51:12 UTC 2017


Quoting ville.syrjala at linux.intel.com (2017-09-01 18:12:51)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> radix_tree_for_each_slot() wants an __rcu annotated pointer for the
> slot. So let's add the annotation.
> 
> Fixes the following sparse warnings:
> i915_gem.c:2217:9: warning: incorrect type in assignment (different address spaces)
> i915_gem.c:2217:9:    expected void **slot
> i915_gem.c:2217:9:    got void [noderef] <asn:4>**
> i915_gem.c:2217:9: warning: incorrect type in assignment (different address spaces)
> i915_gem.c:2217:9:    expected void **slot
> i915_gem.c:2217:9:    got void [noderef] <asn:4>**
> i915_gem.c:2217:9: warning: incorrect type in argument 1 (different address spaces)
> i915_gem.c:2217:9:    expected void [noderef] <asn:4>**slot
> i915_gem.c:2217:9:    got void **slot
> i915_gem.c:2217:9: warning: incorrect type in assignment (different address spaces)
> i915_gem.c:2217:9:    expected void **slot
> i915_gem.c:2217:9:    got void [noderef] <asn:4>**
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Fixes: 96d776345277 ("drm/i915: Use a radixtree for random access to the object's backing storage")
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Looks ok,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list