[Intel-gfx] [PATCH i-g-t 02/12] build: Nuke #ifdef HAVE_CONFIG_H cargo-cult

[Arkadiusz Hiler]

On Mon, Sep 04, 2017 at 12:26:25PM +0200, Szwichtenberg, Radoslaw wrote:
> On Mon, 2017-09-04 at 12:27 +0300, Arkadiusz Hiler wrote:
> > On Mon, Sep 04, 2017 at 10:45:19AM +0200, Daniel Vetter wrote:
> > > On Mon, Sep 04, 2017 at 11:28:09AM +0300, Arkadiusz Hiler wrote:
> > > > On Sat, Sep 02, 2017 at 07:03:56PM +0200, Daniel Vetter wrote:
> > > > > We have it. Daniel Stone said it comes from the X11 transition to the
> > > > > modular build.
> > > > > 
> > > > > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > > > 
> > > > It's also used for Android builds, which lack the generated config.h.
> > > > 
> > > > But is this even used nowadays by anyone?
> We do use IGTs to test kernels used in Android. We do not use the latest version
> of IGT though as we are using one of older kernel versions.
> > > > 
> > > > How we are going to deal with the Android.mk with the transition to
> > > > meson? Can we just drop them?
> > > > 
> > > > Android, in recent releases, is shifting from Makefiles to Soong.
> > > > anyway. <https://android.googlesource.com/platform/build/soong/>
> > > 
> > > Looking at recent igt patches, we've stuffed all the fancy stuff (e.g.
> > > chamelium) into Makefile.am, not Makefile.sources. And no one updated the
> > > android build.
> We dont use/run chamelium tests - I guess we don't use any fancy stuff ;)
> > > 
> > > Judging from that, I think the android build is already firmly in bitrot
> > > territory :-/
> I do have automated build for latest IGTs on android N and so far all builds are
> still passing.

**If you want to help maintaining the Android build,**  I would be happy
to help you with making pre-merge testing out of what you have and
plugging the results into patchwork (and mailing list).

> > > 
> > > So yeah the plan would be to just leave it there, until someone cares
> > > more. From a few googles it looks like meson might be able to
> > > cross-compile into an android environment, but it won't be able to get
> > > integrated into the android image build.
> > 
> > I am actually leaning towards getting rid of it completely from the
> > tree, instead of making the illusion that Android is supported in any
> > way.
> > 
> > If someone will care and pick up the maintenance, this should be easy
> > enough to dig up from the history.
> > 
> Is there no plan at all to support Android long term?

On IGT side of things? Not to my knowledge. We are not building it or
running on anything.

We just need someone who cares, and have resources to keep this
maintained.

-- 
Cheers,
Arek