[Intel-gfx] [PATCH 2/2] drm/i915: io unmap functions want __iomem
Ville Syrjälä
ville.syrjala at linux.intel.com
Mon Sep 4 17:00:25 UTC 2017
On Fri, Sep 01, 2017 at 07:53:05PM +0100, Chris Wilson wrote:
> Quoting ville.syrjala at linux.intel.com (2017-09-01 18:12:52)
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > Don't cast away the __iomem from the io_mapping functions so that
> > sparse won't be so unhappy when we pass the pointer to the unmap
> > functions. Instead let's move the cast to where we actually use the
> > pointer.
> >
> > Fixes the following sparse warnings:
> > i915_gem.c:1022:33: warning: incorrect type in argument 1 (different address spaces)
> > i915_gem.c:1022:33: expected void [noderef] <asn:2>*vaddr
> > i915_gem.c:1022:33: got void *[assigned] vaddr
> > i915_gem.c:1027:34: warning: incorrect type in argument 1 (different address spaces)
> > i915_gem.c:1027:34: expected void [noderef] <asn:2>*vaddr
> > i915_gem.c:1027:34: got void *[assigned] vaddr
> > i915_gem.c:1199:33: warning: incorrect type in argument 1 (different address spaces)
> > i915_gem.c:1199:33: expected void [noderef] <asn:2>*vaddr
> > i915_gem.c:1199:33: got void *[assigned] vaddr
> > i915_gem.c:1204:34: warning: incorrect type in argument 1 (different address spaces)
> > i915_gem.c:1204:34: expected void [noderef] <asn:2>*vaddr
> > i915_gem.c:1204:34: got void *[assigned] vaddr
> >
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> 6 of one, half a dozen of the other. We need to do the __force cast
> somewhere, so whichever is more convenient.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Thanks. Series pushed to dinq.
--
Ville Syrjälä
Intel OTC
More information about the Intel-gfx
mailing list