[Intel-gfx] [PATCH i-g-t v2] igt_core: Skip sync when listing subtests

Tvrtko Ursulin tursulin at ursulin.net
Tue Sep 5 10:38:58 UTC 2017


From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

No need to sync filesystems when only listing subtest.

Extremely marginal benefit of avoid a short stall after make
followed by listing subtests.

v2: Move sync to common_init for consolidation and simplicity.
    (Chris Wilson)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
 lib/igt_core.c | 1 +
 lib/igt_core.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index 99a82d5ae0e1..7e5aa34237f1 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -854,6 +854,7 @@ out:
 		kmsg(KERN_INFO "[IGT] %s: executing\n", command_str);
 		print_version();
 
+		sync();
 		oom_adjust_for_doom();
 		low_mem_killer_disable(true);
 	}
diff --git a/lib/igt_core.h b/lib/igt_core.h
index 619c45c6df90..22b8c2230ea4 100644
--- a/lib/igt_core.h
+++ b/lib/igt_core.h
@@ -234,7 +234,6 @@ void __igt_subtest_group_restore(int);
 #define igt_main \
 	static void igt_tokencat(__real_main, __LINE__)(void); \
 	int main(int argc, char **argv) { \
-		sync(); \
 		igt_subtest_init_parse_opts(&argc, argv, NULL, NULL, NULL, \
 					    NULL, NULL); \
 		igt_tokencat(__real_main, __LINE__)(); \
@@ -275,7 +274,6 @@ void igt_simple_init_parse_opts(int *argc, char **argv,
 #define igt_simple_main \
 	static void igt_tokencat(__real_main, __LINE__)(void); \
 	int main(int argc, char **argv) { \
-		sync(); \
 		igt_simple_init_parse_opts(&argc, argv, NULL, NULL, NULL, \
 					   NULL, NULL); \
 		igt_tokencat(__real_main, __LINE__)(); \
-- 
2.9.5



More information about the Intel-gfx mailing list