[Intel-gfx] [PATCH 1/2] drm/i915: Move device_info.has_snoop into the static tables

[Chris Wilson]

Quoting Ville Syrjälä (2017-09-05 18:28:50)
> On Tue, Sep 05, 2017 at 02:47:34PM +0100, Chris Wilson wrote:
> > Currently we define any !llc machine as using snoop instead. However,
> > some platforms run into trouble using snoop that we would like to
> > disable, and to do so easily we want to be able to use the static
> > device_info tables.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Can't spot any functional changes, assuming I correctly deduced
> which macros are getting updated.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

To double check,

> > diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> > index 05ef5e1b1750..d9c998fc4707 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.c
> > +++ b/drivers/gpu/drm/i915/intel_device_info.c
> > @@ -418,8 +418,6 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
> >       else if (INTEL_INFO(dev_priv)->gen >= 9)
> >               gen9_sseu_info_init(dev_priv);
> >  
> > -     info->has_snoop = !info->has_llc;

I'll make this an actual WARN_ON() in the first patch and send it
separately. Obviously this has to be then removed in the second patch,
but it should give us a little confidence that we are watertight.
-Chris