[Intel-gfx] [PATCH i-g-t] lib: Assert when gem is dead in igt_require_gem

Daniel Vetter daniel.vetter at ffwll.ch
Fri Sep 8 06:38:24 UTC 2017


The function is perhaps a bit renamed, but if a previous tests failed
so badly it left the gpu wrecked, then we should fail, not skip.

Testcases shouldn't ever randomly skip at least, since that just
indicates whether the feature is there or not. Pass/fail is for
whether it's working or not.

Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 lib/ioctl_wrappers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 48750427a0c1..11ae85b26ccd 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -1604,7 +1604,7 @@ void igt_require_gem(int fd)
 	if (ioctl(fd, DRM_IOCTL_I915_GEM_THROTTLE))
 		err = -errno;
 
-	igt_require_f(err == 0, "Unresponsive i915/GEM device\n");
+	igt_assert_f(err == 0, "Unresponsive i915/GEM device\n");
 }
 
 bool gem_has_ring(int fd, unsigned ring)
-- 
2.14.1



More information about the Intel-gfx mailing list