[Intel-gfx] [PATCH igt] lib/igt_dummyload: Use -1 for all engines

[Daniel Vetter]

On Thu, Sep 07, 2017 at 08:57:13PM +0100, Chris Wilson wrote:
> Random change when it copied broke the interface I was using.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  lib/igt_dummyload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c
> index c3516b96..d19b4e5e 100644
> --- a/lib/igt_dummyload.c
> +++ b/lib/igt_dummyload.c
> @@ -86,7 +86,7 @@ static void emit_recursive_batch(igt_spin_t *spin,
>  	int i;
>  
>  	nengine = 0;
> -	if (engine < 0) {
> +	if (engine == -1) {

I have to admit that I don't know what's going on here. I tried this
locally, and both ways the test runs perfectly fine on my snb here. I also
don't see the difference between testing for == -1 and < 0 when we pass -1
seemingly everywhere.

But then CI agrees with you, so really confused now. Care to enlighten the
blind?

Either way, the gtkdoc would also needs to be updated, since that one is
still talking about < 0.

And then halfway through doing this review and trying to get my brain to
work I git pulled and realized that you've pushed this already without any
review or anything. Not cool at all. I presume this was an accident and
not intentionally ignoring everyone else again, so please fix your setup
to make sure this doesn't happen. Maybe separate repos and going through
the m-l/patchwork like on the kernel side, since there this works
perfectly.

Thanks, Daniel

>  		for_each_engine(fd, engine)
>  			if (engine)
>  				engines[nengine++] = engine;
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch