[Intel-gfx] [PATCH i-g-t] lib: Assert when gem is dead in igt_require_gem

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 8 08:10:54 UTC 2017


Quoting Daniel Vetter (2017-09-08 07:38:24)
> The function is perhaps a bit renamed, but if a previous tests failed
> so badly it left the gpu wrecked, then we should fail, not skip.
> 
> Testcases shouldn't ever randomly skip at least, since that just
> indicates whether the feature is there or not. Pass/fail is for
> whether it's working or not.

Not quite, now you are randomly failing a test even before it is testing
anything. Should we fail every test just because we can't open an fd?
-Chris


More information about the Intel-gfx mailing list