[Intel-gfx] [PATCH] drm/i915: Cleanup error paths through eb_lookup_vma()

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 12 20:04:58 UTC 2017


Quoting Tvrtko Ursulin (2017-09-12 16:21:06)
> 
> On 12/09/2017 16:07, Chris Wilson wrote:
> > Following the simplification to a single lookup loop in commit
> > 170fa29b14fa ("drm/i915: Simplify eb_lookup_vmas()") and commit
> > d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr"), we can go
> > one setup further and reorder the error paths so that the state of the
> > local variable obj is always known to the compiler and doesn't need the
> > uninitialized_var markup to squelch a compiler warning.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
[snip]

> Looks good to me.
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Ta, and pushed.
-Chris


More information about the Intel-gfx mailing list