[Intel-gfx] [RFC] drm/i915: Rename global i915 to i915_params

Jani Nikula jani.nikula at linux.intel.com
Wed Sep 13 09:04:28 UTC 2017


On Tue, 12 Sep 2017, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Quoting Ville Syrjälä (2017-09-12 16:36:57)
>> > -module_param_named(modeset, i915.modeset, int, 0400);
>> > +module_param_named(modeset, i915_params.modeset, int, 0400);
>
> We could clear the bulk of this patch
>
> #define i915_param_named(name, T, perm) module_param_named(name, i915.##name, T, perm)
> #define i915_param_named_unsafe(name, T, perm) module_param_named_unsafe(name, i915.##name, T, perm)
>
> as step 1.

That's not unreasonable, as it's all stowed away in one file. Perhaps
throw in MODULE_PARM_DESC to the same macro?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list