[Intel-gfx] [PATCH 4/8] drm/i915: Pass crtc state to i9xx_enable_pll()

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Sep 13 15:20:48 UTC 2017


On Wed, Sep 13, 2017 at 03:41:46PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-09-13 15:08:56)
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Pass the crtc state to i9xx_enable_pll() and use it rather than
> > crtc->config.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> (mutters something about consistency in crtc_state vs pipe_config)

Yeah, that's a PITA. I'm thinking we'll try to take care of that
with coccinelle or sed once the non-trivial cases are sorted.

Also looks like I missed i9xx_set_pll_dividers(). I'll have to fix that
one up as well to get the gmch DPLL code cleaned up.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list