[Intel-gfx] [PATCH v2 00/16] drm/i915: Redo old gmch irq handling

Chris Wilson chris at chris-wilson.co.uk
Thu Sep 14 14:54:35 UTC 2017


Quoting Ville Syrjälä (2017-09-14 15:50:14)
> On Fri, Aug 18, 2017 at 09:36:49PM +0300, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Reposted GMCH irq rework series. A few patches fell out completely
> > since the flip interrupt handling was nuked in the meantime. I also
> > added a patch to remove some more flip irq leftover, and I tossed in
> > a patch to reinstate GMBUS/AUX irqs on gen4/g4x since we no longer
> > use MSI there. I also reordered things a bit to move the HWSTAM stuff
> > towards the end of the series.
> > 
> > Entire series available here:
> > git://github.com/vsyrjala/linux.git gmch_irq_redo_3
> > 
> > Ville Syrjälä (16):
> >   drm/i915: Don't enable/unmask flip interrupts
> >   drm/i915: Clear pipestat consistently
> >   drm/i915: s/GEN5/GEN3/
> >   drm/i915: Use GEN3_IRQ_RESET/INIT on gen3/4
> >   drm/i915: Introduce GEN2_IRQ_RESET/INIT
> >   drm/i915: Setup EMR first on all gen2-4
> >   drm/i915: Eliminate PORT_HOTPLUG_EN setup from gen3/4 irq_postinstall
> >   drm/i915: Unify the appearance of gen3/4 irq_postistall hooks
> >   drm/i915: Remove NULL dev_priv checks from irq_uninstall
> >   drm/i915: Extract PIPESTAT irq handling into separate functions
> >   drm/i915: Rewrite GMCH irq handlers to avoid loops
> >   drm/i915: Gen3 HWSTAM is actually 32 bits
> 
> Above patches above pushed to dinq. Thanks for the reviews.
> 
> >   drm/i915: Mask everything in ring HWSTAM on gen6+ in ringbuffer mode

Enough runs through CI to have picked up anything by now,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

> >   drm/i915: Clean up the HWSTAM mess

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

> >   drm/i915: Reinstate GMBUS and AUX interrupts on gen4/g4x

Hmm.
Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
problem being the disappearance of the reporter to easily verify that we
haven't missed something.

Leaving
> >   drm/i915: Remove duplicated irq_preinstall/uninstall hooks
which I can't remember enough and will need to read again.
-Chris


More information about the Intel-gfx mailing list