[Intel-gfx] [PATCH v17 4/4] drm/i915/selftests: Introduce live tests of private PAT management

[Wang, Zhi A]

Thanks! Have a nice day. :)

-----Original Message-----
From: Chris Wilson [mailto:chris at chris-wilson.co.uk] 
Sent: Thursday, September 14, 2017 4:43 PM
To: Wang, Zhi A <zhi.a.wang at intel.com>; intel-gfx at lists.freedesktop.org; intel-gvt-dev at lists.freedesktop.org
Cc: joonas.lahtinen at linux.intel.com; zhenyuw at linux.intel.com; Wang, Zhi A <zhi.a.wang at intel.com>; Widawsky, Benjamin <benjamin.widawsky at intel.com>; Vivi, Rodrigo <rodrigo.vivi at intel.com>
Subject: Re: [PATCH v17 4/4] drm/i915/selftests: Introduce live tests of private PAT management

Quoting Zhi Wang (2017-09-14 13:39:43)
> Introduce two live tests of private PAT management:
> 
> igt_ppat_init - This test is to check if all the PPAT configurations 
> are written into HW.
> 
> igt_ppat_get - This test performs several sub-tests on 
> intel_ppat_get() and intel_ppat_put().
> 
> The "perfect match" test case will try to get a PPAT entry with an 
> existing value, then check if the returned PPAT entry is the same one.
> 
> The "alloc entries" test case will run out of PPAT table, and check if 
> all the requested values are put into the newly allocated PPAT entries.
> 
> The negative test case will try to generate a new PPAT value, and get 
> it when PPAT table is full.
> 
> The "partial match" test case will generate a parital matched value 
> from the existing PPAT table and try to match it.
> 
> The "re-alloc" test case will try to free and then allocate a new 
> entry when the PPAT table is full.
> 
> The "put entries" test case will free all the PPAT entries that 
> allocated in "alloc entries" test case. It will check if the values of 
> freed PPAT entries turn into ppat->clear_value.
> 
> v11:
> 
> - Fix one indent problem in v10.
> 
> v10:
> 
> - Refine code structure.
> - Introduce "re-alloc" test case. (Chris)
> 
> v9:
> 
> - Refine generate_new_value(). (Chris)
> - Refine failure output. (Chris)
> - Refine test flow of "perfect match". (Chris)
> - Introduce another negative test case after "partial match". (Chris)
> 
> v8:
> 
> - Remove noisy output. (Chris)
> - Add negative test case. (Chris)
> 
> Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Zhi Wang <zhi.a.wang at intel.com>
> Cc: Ben Widawsky <benjamin.widawsky at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

I can't think of any more conditions we need to cover,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris