[Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

[Wang, Zhi A]

Thanks for the comments. V2 has been sent.

-----Original Message-----
From: Vivi, Rodrigo 
Sent: Thursday, September 14, 2017 8:37 PM
To: Wang, Zhi A <zhi.a.wang at intel.com>
Cc: intel-gfx at lists.freedesktop.org; intel-gvt-dev at lists.freedesktop.org; joonas.lahtinen at linux.intel.com; chris at chris-wilson.co.uk; zhenyuw at linux.intel.com; Widawsky, Benjamin <benjamin.widawsky at intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()


well, I wouldn't call this as a typo.
This is a logic fix and deserves a better subject a proper commit message an also fixes tag:

Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")

On Thu, Sep 14, 2017 at 05:24:09PM +0000, Zhi Wang wrote:
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Ben Widawsky <benjamin.widawsky at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
> b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 729ebaf..37cd086 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
>  	};
>  
>  	/* Cache attribute has to be matched. */
> -	if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
> +	if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
>  		return 0;
>  
>  	score |= CA_MATCH;
> --
> 2.7.4
>