[Intel-gfx] [PATCH 3/9] drm/i915/dp: Fix buffer size for sink_irq_esi read

[Ausmus, James]

On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
<dhinakaran.pandiyan at intel.com> wrote:
> The buffer size defined is 16 bytes whereas only 14 bytes are read. Add a
> macro to avoid this discrepancy.
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>

Reviewed-by: James Ausmus <james.ausmus at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 887953c0f495..98e7b96ca826 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -42,6 +42,7 @@
>  #include "i915_drv.h"
>
>  #define DP_LINK_CHECK_TIMEOUT  (10 * 1000)
> +#define DP_DPRX_ESI_LEN 14
>
>  /* Compliance test status bits  */
>  #define INTEL_DP_RESOLUTION_SHIFT_MASK 0
> @@ -3991,15 +3992,9 @@ intel_dp_get_sink_irq(struct intel_dp *intel_dp, u8 *sink_irq_vector)
>  static bool
>  intel_dp_get_sink_irq_esi(struct intel_dp *intel_dp, u8 *sink_irq_vector)
>  {
> -       int ret;
> -
> -       ret = drm_dp_dpcd_read(&intel_dp->aux,
> -                                            DP_SINK_COUNT_ESI,
> -                                            sink_irq_vector, 14);
> -       if (ret != 14)
> -               return false;
> -
> -       return true;
> +       return drm_dp_dpcd_read(&intel_dp->aux, DP_SINK_COUNT_ESI,
> +                               sink_irq_vector, DP_DPRX_ESI_LEN) ==
> +               DP_DPRX_ESI_LEN;
>  }
>
>  static uint8_t intel_dp_autotest_link_training(struct intel_dp *intel_dp)
> @@ -4199,7 +4194,7 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
>         bool bret;
>
>         if (intel_dp->is_mst) {
> -               u8 esi[16] = { 0 };
> +               u8 esi[DP_DPRX_ESI_LEN] = { 0 };
>                 int ret = 0;
>                 int retry;
>                 bool handled;
> --
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 


James Ausmus