[Intel-gfx] [PATCH v3 3/5] drm/i915: Extend private i915_param_named macro with description

Jani Nikula jani.nikula at intel.com
Fri Sep 15 11:37:48 UTC 2017


On Fri, 15 Sep 2017, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Quoting Michal Wajdeczko (2017-09-14 16:08:03)
>> We're always specifying description of each module param in
>> separate macro. Let's combine description into our main macro.
>> Started with Coccinelle, followed by minor cleanup.
>> 
>> @match1@
>> declarer name MODULE_PARM_DESC;
>> identifier n;
>> constant c;
>> @@
>> (
>> -       MODULE_PARM_DESC(n, c);
>> )
>> 
>> @fix1 depends on match1@
>> declarer name i915_param_named;
>> declarer name i915_param_named_unsafe;
>> identifier match1.n;
>> constant match1.c;
>> @@
>> (
>>         i915_param_named(n, ...
>> +       , c
>>         );
>> |
>>         i915_param_named_unsafe(n, ...
>> +       , c
>>         );
>> )
>> 
>> Suggested-by: Jani Nikula <jani.nikula at intel.com>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Cc: Jani Nikula <jani.nikula at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Pushed patches 1-3, undecided for the rest. Thanks for the patches and
review.

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list