[Intel-gfx] [PATCH] uapi/drm/i915: document field usage of drm_i915_perf_oa_config

Chris Wilson chris at chris-wilson.co.uk
Mon Sep 18 11:47:12 UTC 2017


Quoting Lionel Landwerlin (2017-09-18 12:42:41)
> Document the expected length register config pointers (tuple of u32
> values).
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  include/uapi/drm/i915_drm.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
> index fd5c103fe88d..20062f30c1b1 100644
> --- a/include/uapi/drm/i915_drm.h
> +++ b/include/uapi/drm/i915_drm.h
> @@ -1523,6 +1523,11 @@ struct drm_i915_perf_oa_config {
>         __u32 n_boolean_regs;
>         __u32 n_flex_regs;
>  
> +       /**
Not kerneldoc, so /*
> +        * These fields are pointers to tuples of u32 values (register
> +        * address, value). For example the expected length of the buffer
> +        * pointed by mux_regs_ptr should be (2 * sizeof(u32) * n_mux_regs).

s/should be/is/
i.e. expected length of the buffer ... is X.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list