[Intel-gfx] [PATCH 1/2] drm/i915: Silence sparse by using gfp_t

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Sep 18 13:19:42 UTC 2017


On Mon, 2017-09-04 at 12:08 +0100, Chris Wilson wrote:
> Quoting Joonas Lahtinen (2017-09-04 07:50:38)
> > On Fri, 2017-09-01 at 15:57 +0100, Chris Wilson wrote:
> > > Sparse enforces that GFP flags are only manipulated inside gfp_t locals.
> > > 
> > > Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > 
> > Isn't Fixes: bit much for sparse warning?
> 
> Impact: None ?

Well, "Impact: Cosmetic" would be more truthful but complex.

"Backport: None" ?

Could also take the value that is currently causing grief in the Cc:
stable line;

"Backport: v4.8+"

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list