[Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams
Chris Wilson
chris at chris-wilson.co.uk
Mon Sep 18 19:12:25 UTC 2017
Quoting Michal Wajdeczko (2017-09-18 19:55:07)
> Our global struct with params is named exactly the same way
> as new preferred name for the drm_i915_private function parameter.
> To avoid such name reuse lets use different name for the global.
>
> v4: introduction of mkwrite()
>
> Credits-to: Coccinelle
>
> @@
> identifier n;
> expression e;
> @@
>
> (
> - i915.n = e;
> + i915_modparams_mkwrite()->n = e;
> |
> - i915.n++;
> + i915_modparams_mkwrite()->n++;
> |
> - i915.n--;
> + i915_modparams_mkwrite()->n--;
> |
> - i915.n
> + i915_modparams.n
> )
Did this also catch s/&i915&i915_modparams/?
I certainly have no qualms about making it uglier if it inspires more
people to kill off a module parameter or two.
Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
Still umming and ahhing over i915_modparams_mkwrite().
-Chris
More information about the Intel-gfx
mailing list