[Intel-gfx] [PATCH v4 1/3] drm/i915/gvt: Add gvt_debug in i915_params for GVT-g log classification

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Sep 19 13:20:20 UTC 2017


On Tue, 2017-09-19 at 18:03 +0800, Shuo Liu wrote:
> On Tue 19.Sep'17 at 12:11:28 +0300, Joonas Lahtinen wrote:
> > The title should begin with "drm/i915:" not "drm/i915/gvt:".
> 
> My fault. Will correct it.
> > 
> > On Tue, 2017-09-19 at 15:54 +0800, Shuo Liu wrote:
> > 
> > Commit message is always needed.
> 
> OK, will add it.
> > 
> > > Signed-off-by: Shuo Liu <shuo.a.liu at intel.com>
> > 
> > <SNIP>
> > 
> > > @@ -65,6 +65,7 @@ struct i915_params i915 __read_mostly = {
> > >  	.inject_load_failure = 0,
> > >  	.enable_dpcd_backlight = false,
> > >  	.enable_gvt = false,
> > > +	.debug_gvt = 0,
> > 
> > Let's try to keep the struct ordered.
> 
> What's the order? I see it's different with struct definition.

Yeah, it seems to be messed. Leave it as it is, I'll send a fix for all
of them.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list