[Intel-gfx] [PATCH] dim: Accept author x signed-off based on email, but warn.

Rodrigo Vivi rodrigo.vivi at intel.com
Wed Sep 20 12:46:39 UTC 2017


On Wed, Sep 20, 2017 at 11:51:50AM +0000, Jani Nikula wrote:
> On Wed, 20 Sep 2017, Joonas Lahtinen <joonas.lahtinen at linux.intel.com> wrote:
> > On Tue, 2017-09-19 at 10:48 -0700, Rodrigo Vivi wrote:
> >> It seems Patchwork or SMTP servers are messing some patches
> >> and changing the original git's author name on git per "Last, First".
> >> So we end up with a mismatch were signed-off uses one name format
> >> and author is using another format.
> >
> > + Arek,
> >
> > Wasn't this trouble supposed to be fixed?
> 
> Maybe in patchwork context, but it can still happen for people applying
> patches from their MUA. And I doubt it can be reliably "fixed" if the
> author intentionally or inadvertently has differing author and sob
> lines.

hmm... if this is possible we do need to only check for email and move one.

But anyways what I'm seeing a lot recently is this patchwork issue joonas mentioned.
I had to edit few of my patches recently because something on the way changed my
"name last" per "last, name".. and this seems exactly the case with one Manasi's and
one Lee's patch that was impacting the pull request flow.

So if the patchwork is fixed now I believe we can just change the check to email
instead of the name and move on...

Thanks,
Rodrigo.

> 
> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list