[Intel-gfx] [PATCH] dim: Accept author x signed-off based on email.

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Sep 21 13:27:28 UTC 2017


On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote:
> On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
> > It seems Patchwork or SMTP servers are messing some patches
> > and changing the original git's author name on git per "Last, First".
> > So we end up with a mismatch were signed-off uses one name format
> > and author is using another format.
> >
> > So, let's check for email addresses instead.
> >
> > v2: Avoid useles warning and only check for email.
> >
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>

pushed, thanks.

> 
> > ---
> >  dim | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dim b/dim
> > index dbaeb1ec944d..a63000fb67a8 100755
> > --- a/dim
> > +++ b/dim
> > @@ -689,7 +689,7 @@ function checkpatch_commit_push
> >  	sha1=$1
> >  
> >  	# use real names for people with many different email addresses
> > -	author=$(git show -s $sha1 --format="format:%an")
> > +	author=$(git show -s $sha1 --format="format:%ae")
> >  	committer=$(git show -s $sha1 --format="format:%cn")
> >  
> >  	# check for author sign-off
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list