[Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC Load time to dmesg log.

[Tvrtko Ursulin]

On 22/09/2017 21:12, Srivatsa, Anusha wrote:
> Sending to intel-gfx.
> 
> 
>> -----Original Message-----
>> From: Ursulin, Tvrtko
>> Sent: Thursday, September 21, 2017 8:16 AM
>> To: Srivatsa, Anusha <anusha.srivatsa at intel.com>; intel-
>> gfx at lists.freedektop.org
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>; Vetter, Daniel
>> <daniel.vetter at intel.com>; Sundaresan, Sujaritha
>> <sujaritha.sundaresan at intel.com>; Mateo Lozano, Oscar
>> <oscar.mateo at intel.com>; Wajdeczko, Michal <Michal.Wajdeczko at intel.com>
>> Subject: RE: [PATCH 1/2] drm/i915/guc: Add GuC Load time to dmesg log.
>>
>>
>> Hi,
>>
>> For some reason this email hasn't appeared on the mailing list so apologies for a
>> lame Outlook reply.
> 
> Thanks Tvrtko. I corrected the address.
> 
>> I thought we agreed to use a better time source than jiffies (ktime_get()) and also
>> that DRM_NOTE would get emitted only in the case of load time being over some
>> threshold. If it is in realm of normal it should be a normal DRM_DEBUG_DRIVER.
> 
> If it is over 20 ms (the threshold) wont DRM_ERROR be a better option? If it is within that limit, then the info will be in DRM_DEBUG_DRIVER from which the  QA can pick it.

Error only if it fails to load I think. DRM_NOTE was for cases when it 
succeeds but after taking unexpectedly long. Just so it is a level about 
informational.

Regards,

Tvrtko