[Intel-gfx] [PATCH i-g-t 2/2] igt_core: Rework igt_system()

Petri Latvala petri.latvala at intel.com
Mon Sep 25 09:21:42 UTC 2017


On Mon, Sep 25, 2017 at 11:33:51AM +0300, Abdiel Janulgue wrote:
> 
> 
> On 09/21/2017 03:52 PM, Petri Latvala wrote:
> > Instead of redirecting output to pipes and forking, redirect after
> > forking to avoid having to carefully unredirect before logging
> > anything.
> > 
> > igt at tools_test@sysfs_l3_parity had a racy condition where it prints
> > the output of intel_l3_parity prepended by [cmd], but that ended up
> > being printed again prepended by [cmd] because output was redirected,
> > causing outputs to appear multiple times. This patch fixes that.
> > 
> > CC: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>
> > Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> 
> Thanks for fixing this. Series is
> Reviewed-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>

And pushed, thanks for the review.

The CI results were confirmed known noise.



-- 
Petri Latvala


More information about the Intel-gfx mailing list