[Intel-gfx] [PATCH v8 7/8] drm/i915/guc: Disable GuC submission and suspend it prior to i915 reset

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 26 13:52:50 UTC 2017


Quoting Sagar Arun Kamble (2017-09-26 14:24:44)
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index d710f0d..aec3f6b 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -562,6 +562,14 @@ int intel_uc_resume(struct drm_i915_private *dev_priv)
>         return 0;
>  }
>  
> +int intel_uc_reset_prepare(struct drm_i915_private *dev_priv)
> +{
> +       if (i915_modparams.enable_guc_submission)
> +               i915_guc_submission_disable(dev_priv);

General rule of thumb is that in disable we want to check some dependent
state setup by enable, not a user parameter.
-Chris


More information about the Intel-gfx mailing list