[Intel-gfx] [PATCH v8 3/8] drm/i915: Create uC runtime and system suspend/resume helpers

Sagar Arun Kamble sagar.a.kamble at intel.com
Tue Sep 26 14:22:20 UTC 2017



On 9/26/2017 7:13 PM, Chris Wilson wrote:
> Quoting Sagar Arun Kamble (2017-09-26 14:24:40)
>> @@ -2077,7 +2079,7 @@ int i915_gem_runtime_suspend(struct drm_i915_private *dev_priv)
>>                  reg->dirty = true;
>>          }
>>   
>> -       return 0;
>> +       return ret;
> OI! These are written as return 0 because you are very much not meant to
> reach this point with an error.
> -Chris
What if GuC suspend fail? Do we still want to return 0. It might cause 
issues as GuC will be active when PCI Device is set to D3.



More information about the Intel-gfx mailing list