[Intel-gfx] [PATCH] drm/i915: Don't mix inline functions with declarations
Chris Wilson
chris at chris-wilson.co.uk
Tue Sep 26 14:46:20 UTC 2017
Quoting Michal Wajdeczko (2017-09-26 15:37:23)
> We group function forward declarations by file. There is no
> reason to mix these declarations with our unline functions.
Can of worms, can of worms. Our headers are a mess because we mix types
and inlines, and so we end up with code being placed not logically where
one would expect, but because CPP dictates it so.
If you want to make a good improvements towards cleaning them up,
spitting out the types would be my first step.
/wishlist
-Chris
More information about the Intel-gfx
mailing list