[Intel-gfx] [PATCH 1/2] drm/i915: stolen_reserved_base is also dma_addr_t

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 26 20:10:52 UTC 2017


Quoting Paulo Zanoni (2017-09-26 20:29:07)
> The chunk added by this patch was missed by these commits:
> * 920bcd1820a6 ("drm/i915: make i915_stolen_to_physical() return phys_addr_t")
> * c88473878d47 ("drm/i915: Treat stolen memory as DMA addresses")
> 
> The stolen_reserved_base variable contains a memory address for stolen
> memory and our code uses dma_addr_t for pointers to stolen, so it
> makes sense to make it also be dma_addr_t. Notice that the local
> variable inside i915_gem_init_stolen() that stores this pointer is
> even already dma_addr_t.
> 
> This change essentially converts the size to 64 bits where applicable,
> making sure things work in case we ever get crazy enough to put stolen
> that far in memory.

It's defined as residing in the low 4G. Do you have a platform in mind?
-Chris
> 


More information about the Intel-gfx mailing list