[Intel-gfx] [PATCH 0/6] Adding NV12 support

[Srinivas, Vidya]

> -----Original Message-----
> From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Tuesday, September 26, 2017 5:17 PM
> To: Kristian Høgsberg <hoegsberg at gmail.com>
> Cc: Daniel Vetter <daniel at ffwll.ch>; Srinivas, Vidya
> <vidya.srinivas at intel.com>; intel-gfx at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 0/6] Adding NV12 support
> 
> On Tue, Sep 19, 2017 at 02:56:17PM -0700, Kristian Høgsberg wrote:
> > On Mon, Aug 28, 2017 at 3:17 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> > > On Mon, Aug 28, 2017 at 04:22:16PM +0530, Vidya Srinivas wrote:
> > >> This patch series is adding NV12 support for Broxton display after
> > >> rebasing on latest drm-intel-nightly. Initial series of the patches
> > >> can be found here:
> > >> https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.ht
> > >> ml
> > >>
> > >> Previous revision history:
> > >> Patches were initial reviewed last when floated but currently there
> > >> was a design change with respect to
> > >> - the way fb offset is handled
> > >> - the way rotation is handled
> > >> Rebase of the current NV12 patch series has been done as per the
> > >> current changes on drm-intel-nightly.
> > >> Review comments from Ville (12th June 2017) have been addressed
> > >> Review comments from Clinton A Taylor (7th July 2017) have been
> > >> addressed Review comments from Clinton A Taylor (10th July 2017)
> > >> have been addressed. Had missed out tested-by/reviewed-by in the
> > >> patches.
> > >> Fixed that error in this series.
> > >> Review comments from Ville (11th July 2017) addressed.
> > >> Review comments from Paauwe, Bob (29th July 2017) addressed.
> > >>
> > >> Update from last rev:
> > >> Rebased the series as Ville's patches are merged. Previously, this
> > >> series included those floating patches.
> > >>
> > >> Chandra Konduru (6):
> > >>   drm/i915: Set scaler mode for NV12
> > >>   drm/i915: Update format_is_yuv() to include NV12
> > >>   drm/i915: Upscale scaler max scale for NV12
> > >>   drm/i915: Add NV12 as supported format for primary plane
> > >>   drm/i915: Add NV12 as supported format for sprite plane
> > >>   drm/i915: Add NV12 support to intel_framebuffer_init
> > >
> > > Needs serious work on the plane scaling igt (it's atm all broken,
> > > and doesn't test any atomic interactions).
> > >
> > > Then this needs serious work on the nv12 plane igts (which don't yet
> > > exist).
> > >
> > > Then this probably needs pile more igts to test interactions between
> > > everything (e.g. rotation, ...).
> > >
> > > In short: This needs itgs. Lots of them :-)
> > >
> > > Before those exist, and before we've tracked down the bug in the
> > > existing code you're building on it imo makes no sense to start
> > > reviewing these here.
> >
> > Also, this series need to advertise which modifiers work with the new
> > NV12 format by adding a case to
> > skl_sprite_plane_format_mod_supported() and skl_mod_supported().
> 

I am trying to cover as many test cases as possible. Thank you.

> Oh right, which also means we need igts to test the plane formats against
> more modifiers! Well that's kinda part of the tiling tests I guess, at least for
> nv12.

In the current igt test that I have been enhancing, I have added tests for
Tiling and nv12 combination. I have also added sprite and nv12 combination.
Will try to float them as soon as possible. Facing slight issues for larger
Resolution panels (4K) (maybe related to WM etc). Once I test them,
Will float the IGT. Thank you.

> -Daniel
> >
> > Kristian
> >
> > > Thanks, Daniel
> > >
> > >>
> > >>  drivers/gpu/drm/i915/i915_reg.h      |  1 +
> > >>  drivers/gpu/drm/i915/intel_atomic.c  |  8 ++++-
> > >> drivers/gpu/drm/i915/intel_display.c | 67
> +++++++++++++++++++++++++++++-------
> > >>  drivers/gpu/drm/i915/intel_drv.h     |  3 +-
> > >>  drivers/gpu/drm/i915/intel_sprite.c  | 34 ++++++++++++++----
> > >>  5 files changed, 92 insertions(+), 21 deletions(-)
> > >>
> > >> --
> > >> 1.9.1
> > >>
> > >> _______________________________________________
> > >> Intel-gfx mailing list
> > >> Intel-gfx at lists.freedesktop.org
> > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >
> > > --
> > > Daniel Vetter
> > > Software Engineer, Intel Corporation http://blog.ffwll.ch
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch